Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tetra-gtk-theme: 201905 -> 201905r1 #62132

Merged
merged 1 commit into from Jun 9, 2019
Merged

tetra-gtk-theme: 201905 -> 201905r1 #62132

merged 1 commit into from Jun 9, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
tetra-gtk-theme: 201905 -> 201905r1
b2ccf38 
- Rename to adementary-theme, following upstream
- Update to version 201905r1
@ofborg ofborg bot requested a review from dtzWill May 27, 2019 20:54
@c0bw3b
Copy link
Contributor

c0bw3b commented May 28, 2019 •
edited

Result of nix-review pr 62132 1

1 package were build:
  • adementary-theme

Is it worth adding an alias in aliases.nix ? Or throw a message pointing to the new name.
cc @dtzWill

pull bot pushed a commit to milibopp/nixpkgs that referenced this pull request Jun 9, 2019
@vcunat
Merge NixOS#62132: tetra-gtk-theme: 201905 -> 201905r1
308706f 
And rename, without an alias (probably fine for this, I think).
@vcunat vcunat merged commit b2ccf38 into NixOS:master Jun 9, 2019
@romildo romildo deleted the upd.tetra-gtk-theme branch June 10, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @c0bw3b @vcunat