Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectacle: fix qdbus path in desktop shortcut #62170

Merged
merged 1 commit into from May 28, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented May 28, 2019

Motivation for this change

Since KDE 19.04 the desktop shortcut of Spectacle is calling qdbus which is not in the PATH

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre requested a review from ttuegel as a code owner May 28, 2019 19:51
@nyanloutre
Copy link
Member Author

@GrahamcOfBorg build spectacle

@worldofpeace
Copy link
Contributor

Thanks for fixing this @nyanloutre ❇️ , I find it best to hardcode the path to qdbus like this.

@nyanloutre nyanloutre deleted the fix-kde-spectacle branch May 28, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants