Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtins: 4.0 -> 4.2 / compactor: 0.11.1 -> 0.12.2 #62090

Merged
merged 2 commits into from May 27, 2019
Merged

libtins: 4.0 -> 4.2 / compactor: 0.11.1 -> 0.12.2 #62090

merged 2 commits into from May 27, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 26, 2019 •
edited

Motivation for this change

Version updates
Fix compactor builds (currently failing on Hydra)

cc @fdns

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 26, 2019

Result of nix-review pr 62090 on NixOS

2 package were build:
  • compactor
  • libtins

@infinisil infinisil merged commit e173638 into NixOS:master May 27, 2019
@c0bw3b c0bw3b deleted the pkg/compactor branch May 27, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @infinisil