Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: init openstf #62176

Merged
merged 1 commit into from May 29, 2019
Merged

nodePackages: init openstf #62176

merged 1 commit into from May 29, 2019

Conversation

jollheef
Copy link
Member

Hello,

This commit introduce npm package for openstf.io.

Node v10 is not yet supported by STF, so it's defined only for node v8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jollheef
Copy link
Member Author

@matthew-piziak, is it still "change only json, do not regenerate *.nix", or I need to generate?

@matthew-piziak
Copy link
Contributor

@jollheef That's right. @ryantm can you take a look? I can regenerate after it's merged.

@ryantm ryantm merged commit 60b59c3 into NixOS:master May 29, 2019
@ryantm
Copy link
Member

ryantm commented May 29, 2019

@matthew-piziak 👍

@matthew-piziak
Copy link
Contributor

Regenerating…

@matthew-piziak
Copy link
Contributor

Regenerated here @ryantm @jollheef #62221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jollheef @matthew-piziak @ryantm