Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: Enable IPv6 support for IPVS (CONFIG_IP_VS_IPV6 y) #62172

Merged
merged 1 commit into from Jun 8, 2019
Merged

kernel: Enable IPv6 support for IPVS (CONFIG_IP_VS_IPV6 y) #62172

merged 1 commit into from Jun 8, 2019

Conversation

dsx
Copy link
Contributor

@dsx dsx commented May 28, 2019

Motivation for this change

IPv6 support for IPVS exists since 2.6.10 (released on December 24, 2004). With massive IPv6 adoption world-wide it is quite reasonable to have this enabled by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dsx dsx marked this pull request as ready for review May 29, 2019 01:50
@memberbetty
Copy link
Contributor

Have you been using it with that option on many machines for an extended period of time?

If not, please turn this into something conditional on the value of networking.enableIPv6 in a NixOS module.

@dsx
Copy link
Contributor Author

dsx commented Jun 2, 2019

As far as IPVS with IPv6 goes, it has been battle-tested on many servers since around 2008 if memory serves me. Although those most definetely weren't NixOS deployments, I don't see how NixOS would be any different from other Linux distributions in this regard.

@memberbetty
Copy link
Contributor

I am strongly against this kind of approach of first making a change and then hoping it doesn't break.

@7c6f434c
Copy link
Member

7c6f434c commented Jun 3, 2019

This change just includes the support code into the kernel, it doesn't actually setup anything with IPVS (by default)

@fpletz
Copy link
Member

fpletz commented Jun 3, 2019

If not, please turn this into something conditional on the value of networking.enableIPv6 in a NixOS module.

This would trigger a kernel rebuild and is therefore not desirable.

As Debian has this enabled since 2010 I don't see a reason not to enable it by default. I doubt we have to deal with any fallout due to this change.

fpletz
fpletz approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but please prefix the commit message with "kernel: ".

@fpletz fpletz merged commit 643de9b into NixOS:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dsx @memberbetty @7c6f434c @fpletz @Janik-Haag