Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpsl: 0.20.2 -> 0.21.0 / publicsuffix-list: init at 2019-05-24 #62070

Closed
wants to merge 2 commits into from

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 25, 2019

Motivation for this change
  • publicsuffix-list is now its own data derivation so it can be reused by other ; and it allows semi-automatic update of this dataset (right now we're shipping an outdated list)
  • libpsl update taking the system-wide PSL as input
  • switched from icu to libidn2+libunistring in libpsl because it is upstream default and it reduces overall closure size
  • added myslef as maintainer of both derivations
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ /nix/store/57dvdfm90pkckfm7y47kljxsl7szh4rw-libpsl-0.21.0/bin/psl --version
psl 0.21.0 (0x001500)
libpsl 0.21.0 (+libidn2/2.1.1)

Copyright (C) 2014-2018 Tim Ruehsen
License: MIT

$ /nix/store/57dvdfm90pkckfm7y47kljxsl7szh4rw-libpsl-0.21.0/bin/psl --print-info
dist filename: /nix/store/szphjhh0j68yhddyw2zh8ykr00mhd1r2-publicsuffix-list-2019-05-24/share/publicsuffix/public_suffix_list.dat
builtin suffixes: 8753
builtin exceptions: 8
builtin wildcards: 64
builtin filename: /nix/store/szphjhh0j68yhddyw2zh8ykr00mhd1r2-publicsuffix-list-2019-05-24/share/publicsuffix/public_suffix_list.dat
builtin file time: 1 (jeu., 01 janv. 1970 01:00:01 CET)
builtin SHA1 file hash: 82a6723fa5ebb37bbbd0a32f6e2f614be275c932
builtin outdated: 0
$ nix path-info -sSh /nix/store/k746lpxpvm9h9bjy793k985i6manryr5-libpsl-0.20.2-list-2017-02-03
/nix/store/k746lpxpvm9h9bjy793k985i6manryr5-libpsl-0.20.2-list-2017-02-03        115.8K   64.2M

$ nix path-info -sSh /nix/store/57dvdfm90pkckfm7y47kljxsl7szh4rw-libpsl-0.21.0
/nix/store/57dvdfm90pkckfm7y47kljxsl7szh4rw-libpsl-0.21.0        116.8K   28.9M

c0bw3b added a commit to c0bw3b/nixpkgs that referenced this pull request May 26, 2019
c0bw3b added a commit to c0bw3b/nixpkgs that referenced this pull request May 26, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 26, 2019

Pushed to staging in fe15488 and 846b12b

@c0bw3b c0bw3b closed this May 26, 2019
@c0bw3b c0bw3b deleted the pkg/psl branch November 5, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant