Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.0.6 -> 6.0.8 #62067

Merged
merged 1 commit into from May 26, 2019
Merged

virtualbox: 6.0.6 -> 6.0.8 #62067

merged 1 commit into from May 26, 2019

Conversation

ambrop72
Copy link
Contributor

Some of the patches were removed because of upstream fixes.

Due to makefile refactoring the kernel modules package didn't build right (only vboxdrv got built, not the other two modules). I don't know how the current code was supposed to work, but I simplified the package to build the modules how they are supposed to be (make and make install).

Works fine and the testsnixosTests.virtualbox pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from svanderburg and flokli May 25, 2019 20:01
@flokli
Copy link
Contributor

flokli commented May 25, 2019

Changelog:

Core: fix saved state resume failures (bugs #18265 and #18331)
User interface: show full file location in New Medium window.
User interface: fix mouse click pass-through problems in multi-screen virtual machines (6.0.6 regression, bug #18567)
Graphics: fixed a crash when powering off a VM without graphics controller (bug #18570)
API: partial fix for dealing with VM config conflicting with other VMs related to medium UUIDs, now correctly flags VM as inaccessible (bug #17908)
Windows hosts: Support paths longer than 4096 characters on in shared folders
Linux hosts: fix kernel module build breakage in non-default build set-ups (bug #18620, thank you Ambroz Bizjak)
Linux hosts: fix kernel module build breakage in debug build set-ups (bug #18621, thank you Ambroz Bizjak)
Windows guests: notice file size increases in shared folders which were missed in certain cases
Linux guests: make shared folders work with Linux 3.16.35
Linux guests: fix incorrectly read-only shared folders (bug #18345)

@flokli
Copy link
Contributor

flokli commented May 25, 2019

@GrahamcOfBorg test virtualbox

@flokli flokli merged commit c689671 into NixOS:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrop72 @flokli