Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swig: use pname and standardize meta #62158

Merged
merged 1 commit into from May 29, 2019
Merged

swig: use pname and standardize meta #62158

merged 1 commit into from May 29, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented May 28, 2019 •
edited

  • pname makes it easier to override the version in an overlay and looks generally cleaner
  • Updated the meta sections to match between the various versions

No real functional change, just cleanup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
swig: use pname and standardize meta
072f4d6 
- pname makes it easier to override the version in an overlay and looks generally cleaner
- Updated the meta sections to match between the various versions

No real functional change, just cleanup.
@bhipple
Copy link
Contributor Author

bhipple commented May 28, 2019

@GrahamcOfBorg build swig3 swig2 swig1

@bhipple
Copy link
Contributor Author

bhipple commented May 28, 2019

CC @Mic92 @matthewbauer

bhipple
bhipple commented May 28, 2019
View reviewed changes
pkgs/development/tools/misc/swig/3.x.nix
@@ -17,8 +17,8 @@ stdenv.mkDerivation rec {

configureFlags = [ "--without-tcl" ];

# Disable ccache documentation as it needs yodl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing a small grammar mistake while I'm here, and moving the comment out of the postPatch so it can be updated without a rebuild.

@Mic92 Mic92 merged commit 9cce7ea into NixOS:staging May 29, 2019
@bhipple bhipple deleted the fix/swig branch July 16, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @Mic92