Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srandrd: init at v0.6.0 #62106

Merged
merged 1 commit into from May 28, 2019
Merged

srandrd: init at v0.6.0 #62106

merged 1 commit into from May 28, 2019

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented May 27, 2019

Motivation for this change

srandrd is a handy utility to run a command when display configuration changes.

It's a simple c script without many dependencies, and I tested that it works on my NixOS machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


meta = {
homepage = https://github.com/jceb/srandrd;
description = "srandrd - simple randr daemon";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fits CONTRIBUTING.md as per

meta.description should:
Be capitalized.
Not start with the package name.

pkgs/tools/X11/srandrd/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved

makeFlags = "PREFIX=$(out)";

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta = with stdenv.lib; {... might be neater

makeFlags = "PREFIX=$(out)";

meta = {
homepage = https://github.com/jceb/srandrd;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/jceb/srandrd;
homepage = "https://github.com/jceb/srandrd";


meta = {
homepage = https://github.com/jceb/srandrd;
description = "srandrd - simple randr daemon";
Copy link
Member

@Lassulus Lassulus May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "srandrd - simple randr daemon";
description = "Simple randr daemon";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it capitalized.

@utdemir
Copy link
Member Author

utdemir commented May 27, 2019

Thanks @mmahut @alexarice and @Lassulus, I applied your suggestions to the PR.

Can you have another look please?

@Lassulus
Copy link
Member

tested with nix-review, wrote a little script to automatically enable connected outputs.

@Lassulus Lassulus merged commit 35494ac into NixOS:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants