New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
srandrd: init at v0.6.0 #62106
srandrd: init at v0.6.0 #62106
Conversation
pkgs/tools/X11/srandrd/default.nix
Outdated
|
||
meta = { | ||
homepage = https://github.com/jceb/srandrd; | ||
description = "srandrd - simple randr daemon"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't fits CONTRIBUTING.md as per
meta.description should:
Be capitalized.
Not start with the package name.
pkgs/tools/X11/srandrd/default.nix
Outdated
|
||
makeFlags = "PREFIX=$(out)"; | ||
|
||
meta = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta = with stdenv.lib; {...
might be neater
pkgs/tools/X11/srandrd/default.nix
Outdated
makeFlags = "PREFIX=$(out)"; | ||
|
||
meta = { | ||
homepage = https://github.com/jceb/srandrd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = https://github.com/jceb/srandrd; | |
homepage = "https://github.com/jceb/srandrd"; |
pkgs/tools/X11/srandrd/default.nix
Outdated
|
||
meta = { | ||
homepage = https://github.com/jceb/srandrd; | ||
description = "srandrd - simple randr daemon"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "srandrd - simple randr daemon"; | |
description = "Simple randr daemon"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it capitalized.
Thanks @mmahut @alexarice and @Lassulus, I applied your suggestions to the PR. Can you have another look please? |
tested with nix-review, wrote a little script to automatically enable connected outputs. |
Motivation for this change
srandrd is a handy utility to run a command when display configuration changes.
It's a simple c script without many dependencies, and I tested that it works on my NixOS machine.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)