Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throttled: fix for Intel CPU throttling issues #62101

Merged
merged 2 commits into from Jun 11, 2019
Merged

throttled: fix for Intel CPU throttling issues #62101

merged 2 commits into from Jun 11, 2019

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

throttled is a project that fixes some of the Intel CPU throttling issues primarily (but not exclusively) affecting Lenovo machines.

It is a slightly less ad-hoc version of the fix that we have in nixos-hardware, and hopefully could replace it. Crucially, it seems to be maintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@michaelpj michaelpj requested a review from infinisil as a code owner May 26, 2019 22:53
@michaelpj michaelpj force-pushed the imp/lenovo-throttled branch 2 times, most recently from 34e899b to 178ab04 Compare May 27, 2019 13:07
@michaelpj
Copy link
Contributor Author

ping

@michaelpj
Copy link
Contributor Author

Sorry to nag again, but I think I've fixed this now?

@Mic92 Mic92 merged commit e829aee into NixOS:master Jun 11, 2019
@michaelpj michaelpj mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@infinisil infinisil infinisil left review comments

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelpj @Mic92 @infinisil @c0bw3b