Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-xhtml2pdf: init at 0.2.3 #61758

Merged
merged 1 commit into from May 26, 2019
Merged

python-xhtml2pdf: init at 0.2.3 #61758

merged 1 commit into from May 26, 2019

Conversation

ecoughlan
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ecoughlan ecoughlan requested a review from FRidh as a code owner May 20, 2019 17:24
@marsam marsam merged commit 8d219aa into NixOS:master May 26, 2019
@marsam
Copy link
Contributor

marsam commented May 26, 2019

Sorry for the delay, built and tested locally on NixOS and darwin.
Thanks!

@ecoughlan ecoughlan deleted the python-xhtml2pdf branch May 27, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ecoughlan @marsam