Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrootenv segfaulting on exit #62091

Merged
merged 1 commit into from May 27, 2019
Merged

Fix chrootenv segfaulting on exit #62091

merged 1 commit into from May 27, 2019

Conversation

L-as
Copy link
Member

@L-as L-as commented May 26, 2019

Motivation for this change

chrootenv (and therefore all users of FHS envs) segfaults on exit if you allow more than 2^19 file descriptors per process.

Things done

glibc 2.27 (and possibly other versions) can't handle an nopenfd value larger than 2^19 in ntfw, so the value of getdtablesize() was clamped to 2^19.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@L-as
Fix chrootenv segfaulting on exit
50c215d 
glibc 2.27 (and possibly other versions) can't handle an `nopenfd` value larger than 2^19 in `ntfw`, which is problematic if you've set the maximum number of fds per process to a value higher than that.
@infinisil infinisil merged commit 55014a0 into NixOS:master May 27, 2019
@infinisil infinisil mentioned this pull request May 27, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@L-as @infinisil