cargo-make: 0.19.1 -> 0.19.2 #62077
Merged
cargo-make: 0.19.1 -> 0.19.2 #62077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahut
approved these changes
May 26, 2019
infinisil
reviewed
May 26, 2019
| }; | ||
| cargo-lock = fetchurl { | ||
| url = "https://gist.githubusercontent.com/xrelkd/e4c9c7738b21f284d97cb7b1d181317d/raw/8a12a07cafeff4ef4a01983f5243dd8c95d10c48/cargo-make-0.19.1-Cargo.lock"; | ||
| sha256 = "0v2hygkpsyjcpzrgyzl5mah0y8gmprfbnz7kn4hh6zfhz2lhqqwm"; | ||
| url = "https://gist.githubusercontent.com/xrelkd/e4c9c7738b21f284d97cb7b1d181317d/raw/f1e6360acfbe5ae573f8f31a82a5c881a6f0ed68/cargo-make-Cargo.lock"; |
There was a problem hiding this comment.
Indentation is messed up here
There was a problem hiding this comment.
@infinisil Thanks for the review!
The problem has been corrected.
|
@mmahut Thanks for the review, but fyi, ofBorg didn't actually do any builds here, it only did evaluation checks. ofBorg builds get done when either a trusted user makes a PR, or a trusted user issues a command like this (see https://github.com/NixOS/ofborg for more info): @GrahamcOfBorg build cargo-make (In the checks you can see "cargo-make on x86_64-linux" and "cargo-make on x86_64-darwin" now) |
|
@infinisil thank you for the clarification, I got it confused! In the future I will distinguish between a build and an eval. |
|
@mmahut @infinisil Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
cargo-maketo the latest release.https://github.com/sagiegurari/cargo-make/releases/tag/0.19.2
Note:
doCheckis set asfalse.Some tests fail because they need network access. However, Travis ensures a proper build.
https://travis-ci.org/sagiegurari/cargo-make/jobs/537150407
https://travis-ci.org/sagiegurari/cargo-make/jobs/537150408
https://travis-ci.org/sagiegurari/cargo-make/jobs/537150409
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)