Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New znc modules #62075

Merged
merged 4 commits into from May 27, 2019
Merged

New znc modules #62075

merged 4 commits into from May 27, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented May 26, 2019

Motivation for this change

Switching a FreeBSD server I use for ZNC to NixOS and there aren't a lot of ZNC modules. I added a few I needed and more.

Things done

Added ignore and clientaway from znc-contrib
Added palaver

I was going to add more of the znc-contrib but I wasn't able to figure them out (yubikey uses extra C++ libraries and 2 are python; one of which is a rewrite of privmsg, which we already have, so w/e)

I've added them to the modules that load and ZNC still starts so I think that means they're working.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build zncModules.clientaway
@GrahamcOfBorg build zncModules.ignore
@GrahamcOfBorg build zncModules.palaver

@infinisil infinisil merged commit 2dd05f1 into NixOS:master May 27, 2019
@infinisil
Copy link
Member

Looking good, thanks :)

@Kiwi Kiwi deleted the new-zncModules branch June 20, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants