Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.salmon-mail: fix build #62117

Closed
wants to merge 1 commit into from
Closed

pythonPackages.salmon-mail: fix build #62117

wants to merge 1 commit into from

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented May 27, 2019 •
edited

Motivation for this change

Python package salmon-mail failed to build because it had set an upper bound for a dependency and nixpkgs contains too new version of that dependency. This upper bound seems to be just some installation convenience thing, not a compatibility issue, so I just removed the upper bound.

For more information:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner May 27, 2019 12:48
@risicle
Copy link
Contributor

risicle commented May 27, 2019

Build fails for me on macos 10.13: https://gist.github.com/risicle/0b9e661fa0dc49d6f92d9225f6f5c86c

@jluttine
Copy link
Member Author

@risicle A response from upstream: moggers87/salmon#90 (comment)

@risicle
Copy link
Contributor

risicle commented May 28, 2019 •
edited

Interesting - I wonder if they're picking a weird TMPDIR or something...

It's possible this is just showing up as a bug for us because of the sandbox that Nix runs the tests in.

@jluttine jluttine mentioned this pull request May 30, 2019
Merged
10 tasks
@jluttine
Copy link
Member Author

Use #62249 instead.

@jluttine jluttine closed this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @risicle