Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgs.biber for Darwin (alt) #62156

Closed
wants to merge 1 commit into from
Closed

Fix pkgs.biber for Darwin (alt) #62156

wants to merge 1 commit into from

Conversation

boronine
Copy link
Contributor

@boronine boronine commented May 28, 2019

Motivation for this change

This PR contains an alternative solution for #35477

See comment: #35477 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented May 28, 2019

This needs to target staging.

cc @volth @dtzWill

@boronine boronine changed the base branch from master to staging May 28, 2019 14:11
@boronine
Copy link
Contributor Author

@veprbl rebased onto staging

@veprbl
Copy link
Member

veprbl commented May 28, 2019

I am not very happy with bloating buildPerlModule/buildPerlPackage in order to fix less than 0.1% of its use cases. Those could be addressed either in buildPerlProgram or just by adding single line (wrapProgram or patchShebangs) in the derivation's postInstall.

I don't understand how introducing buildPerlProgram is going to help reducing the bloat here. You want to move shebang patching out from builder.sh? If yes, then I think that this is an orthogonal problem. It is not introduced by this PR, the code for patching shebangs is already in the builder.

The single line in postInstall would be needed for 0.1% of packages which may be, say, 10 to 20 of identical lines across nixpkgs. I thought this was the reason why we are trying to refactor this into an option for the builder.

@boronine
Copy link
Contributor Author

Hi @volth, thank you for reviewing this. When I encountered this shebang issue (#35353), my initial instinct was that this shebang injection mechanism should eventually be removed as not robust. If this is the eventual goal, then perhaps the builder.sh bloat can be tolerated as an intermediate step.

@veprbl veprbl closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants