Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass: Use latest buildGoPackage #62094

Merged
merged 1 commit into from May 26, 2019
Merged

gopass: Use latest buildGoPackage #62094

merged 1 commit into from May 26, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Go 1.10 is marked as broken on Darwin(see https://github.com/NixOS/nixpkgs/pull/56744/files#diff-0ed9de1390061094a04a4f8c69e29a87R185 in #56744)
There's no reason not to use the latest available Go version to build gopass though, since it builds just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit 7f09bd6 into NixOS:master May 26, 2019
@marsam
Copy link
Contributor

marsam commented May 26, 2019

built and tested locally on NixOS and Darwin
Thanks!

@rvolosatovs rvolosatovs deleted the fix/gopass branch May 27, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvolosatovs @marsam