Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qView: init at 2.0 #62161

Merged
merged 2 commits into from May 29, 2019
Merged

qView: init at 2.0 #62161

merged 2 commits into from May 29, 2019

Conversation

acowley
Copy link
Contributor

@acowley acowley commented May 28, 2019

A fast, unobtrusive Qt-based image viewer.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@acowley
Package the qView image viewer
fbc46ae 
A fast, unobtrusive Qt-based image viewer.
aanderse
aanderse requested changes May 28, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just a few minor nit picks. Will take an in depth look when I get a chance.

pkgs/applications/graphics/qview/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/qview/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/qview/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build qview

@aanderse aanderse merged commit 8ae3e73 into NixOS:master May 29, 2019
@aanderse
Copy link
Member

@acowley Thank you for your contribution to nixpkgs! 🎉

@acowley
Copy link
Contributor Author

acowley commented May 29, 2019

Thank you for the fast and helpful review, @aanderse!

@acowley acowley deleted the qview2 branch May 29, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acowley @aanderse