Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord-go: 2.0.26 -> 2.0.27 #62162

Merged
merged 1 commit into from May 29, 2019
Merged

trezord-go: 2.0.26 -> 2.0.27 #62162

merged 1 commit into from May 29, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented May 28, 2019

Motivation for this change

https://github.com/trezor/trezord-go/releases/tag/v2.0.27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jb55
jb55 approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ git shortlog v2.0.26..v2.0.27

Karel Bilek (1):
      core: Use idiomatic context, not struct channels

Pavol Rusnak (5):
      Merge pull request #150 from tsusanka/tsusanka/version
      Merge pull request #149 from karel-3d/use_context_not_chans
      windows: rename code signing files
      windows: fix last commit
      bump version to 2.0.27

Tomas Susanka (2):
      Print version after start
      Add CLI flag to print version

c0bw3b
c0bw3b approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 62162 1

1 package were build:
  • trezord

@c0bw3b c0bw3b merged commit 05c5075 into NixOS:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @jb55 @c0bw3b