Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.92.2 -> 0.93.2 #61754

Merged
merged 3 commits into from May 27, 2019
Merged

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

It seems the asynctest bump leads to one mitmproxy check failing:

Result of nix-review pr 61754

1 package failed to build:
  • mitmproxy
7 package were build:
  • home-assistant
  • home-assistant-cli
  • python37Packages.aioresponses
  • python37Packages.asynctest
  • python37Packages.pyatv
  • python37Packages.pyhomematic
  • python37Packages.zeep

The failing test trace:

__________ TestTermLog.test_output[None-expected_out0-expected_err0] ___________

self = <test.mitmproxy.addons.test_termlog.TestTermLog object at 0x7fffeb8d4940>
outfile = None, expected_out = ['one', 'three'], expected_err = ['four']
capfd = <_pytest.capture.CaptureFixture object at 0x7fffeb8cc5c0>

    @pytest.mark.usefixtures('capfd')
    @pytest.mark.parametrize('outfile, expected_out, expected_err', [
        (None, ['one', 'three'], ['four']),
        (sys.stdout, ['one', 'three', 'four'], []),
        (sys.stderr, [], ['one', 'three', 'four']),
    ])
    def test_output(self, outfile, expected_out, expected_err, capfd):
    # ...

@dotlambda dotlambda changed the title home-assistant: 0.92.2 -> 0.93.1 home-assistant: 0.92.2 -> 0.93.2 May 27, 2019
@dotlambda
Copy link
Member Author

@GrahamcOfBorg test home-assistant

@dotlambda
Copy link
Member Author

@c0bw3b That bump was already merged in #61880.

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build mitmproxy

@c0bw3b
Copy link
Contributor

c0bw3b commented May 27, 2019

It still builds fine on Hydra so I guess my local test was a transient failure...

@dotlambda dotlambda merged commit ad4bd3b into NixOS:master May 27, 2019
@dotlambda dotlambda deleted the home-assistant-0.93 branch May 27, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants