Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnuradio: rename plugins gnuradio-* -> gr-* #62115

Merged
merged 1 commit into from May 28, 2019
Merged

gnuradio: rename plugins gnuradio-* -> gr-* #62115

merged 1 commit into from May 28, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented May 27, 2019 •
edited

Motivation for this change

Harmonize plugin names with repology (see #60006). In most cases this is also the official package name of the plugins. This will allow for auto updater to check for updates.

Things done
  • Globally renamed all plugins to gr-*
  • added aliases to maintain backwards compatibility
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
gnuradio: rename plugins gnuradio-* -> gr-*
069167d 
* harmonize plugin names with repology
* added aliases to maintain backwards compatability
@ofborg ofborg bot requested review from bjornfor, the-kenny and fpletz May 27, 2019 12:47
@infinisil infinisil merged commit 030eb35 into NixOS:master May 28, 2019
@markuskowa markuskowa deleted the fix-gr-rename branch May 28, 2019 08:03
tomberek
tomberek approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs on Ubuntu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@tomberek tomberek tomberek approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @bjornfor @tomberek @infinisil