Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.applicationinsights: init at 0.11.9 #62163

Merged
merged 3 commits into from Jun 2, 2019
Merged

python.pkgs.applicationinsights: init at 0.11.9 #62163

merged 3 commits into from Jun 2, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Add more Azure support into Nixos packages.

Not related to #60435 (separate pypi package and repo)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh result/
/nix/store/hgyfrsfw3my1p14lbsmdz02ynmqz7cc0-python3.5-applicationinsights-0.11.9 95.0M

@jonringer jonringer requested a review from FRidh as a code owner May 28, 2019 18:31
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python37.pkgs.applicationinsights python36.pkgs.applicationinsights python35.pkgs.applicationinsights python.pkgs.applicationinsights pypy.pkgs.applicationinsights python37.pkgs.portalocker python36.pkgs.portalocker python35.pkgs.portalocker python.pkgs.portalocker
pypy.pkgs.portalocker

worldofpeace
worldofpeace suggested changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call packages from pkgs/top-level/python-packages.nix

@jonringer
Copy link
Contributor Author

Please call packages from pkgs/top-level/python-packages.nix

Yea, got used to doing version bumps/patches forgot about adding the top-level entries, all fixed now :) @worldofpeace

@worldofpeace
Copy link
Contributor

Please call packages from pkgs/top-level/python-packages.nix

Yea, got used to doing version bumps/patches forgot about adding the top-level entries, all fixed now :) @worldofpeace

Thanks, let's see if it builds everywhere 👍

@GrahamcOfBorg build python37.pkgs.applicationinsights python36.pkgs.applicationinsights python35.pkgs.applicationinsights python.pkgs.applicationinsights pypy.pkgs.applicationinsights python37.pkgs.portalocker python36.pkgs.portalocker python35.pkgs.portalocker python.pkgs.portalocker
pypy.pkgs.portalocker

@worldofpeace worldofpeace merged commit 40b40f3 into NixOS:master Jun 2, 2019
@worldofpeace
Copy link
Contributor

Thanks @jonringer for contributing 🌸

@jonringer jonringer deleted the applicationinsights branch June 3, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace