New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perl: get perl in HOST_PATH for patch-shebangs #61631
Conversation
As I put on the issue, I have tested that this fixes the problem I had with biber. I haven't installed full texlive as it would require another llvm compile but can't see why it would be any different. |
Maybe that's unrelated to this change https://hydra.nixos.org/build/92065248 |
Oh I'm very glad this sort of thing was the cause--I've been experiencing all manner of perl shebang madness and it was so close but still requiring attention in a few places (such as biber). Will pull in and test a bit, don't delay on my account but I'll hopefully report back with some positive news once in a $rebuild_completion_period or so. ⌚ |
This pr clearly doesn't have that commit 0a64e79. |
ping @volth . Any insights? |
So from what you said this is an atypical issue and any anticipated regressions would be limited as it's limited already. 👍 Making it less of an unattractive "fix". |
Hmm and not having it causing issues for others right away dhbw-stginf16a/nosql-book#23 🤣 |
I am hoping we can also revert 5a5a597 with this |
Can this go in? |
Anything that installs a perl script that needs to be executed will need the host platform's perl. That should be a lot of scripts that it isn't worth patching these manually. We should revert those fixes. |
Motivation for this change
Fixes #61520
Regression from a1533df 61bc03c
cc @alexarice @volth @matthewbauer
special thanks to @alexarice for bisecting
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)