Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: get perl in HOST_PATH for patch-shebangs #61631

Merged
merged 1 commit into from May 28, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 17, 2019

Motivation for this change

Fixes #61520

Regression from a1533df 61bc03c

cc @alexarice @volth @matthewbauer

special thanks to @alexarice for bisecting
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexarice
Copy link
Contributor

As I put on the issue, I have tested that this fixes the problem I had with biber. I haven't installed full texlive as it would require another llvm compile but can't see why it would be any different.

@worldofpeace
Copy link
Contributor Author

Maybe that's unrelated to this change https://hydra.nixos.org/build/92065248

@dtzWill
Copy link
Member

dtzWill commented May 17, 2019

Oh I'm very glad this sort of thing was the cause--I've been experiencing all manner of perl shebang madness and it was so close but still requiring attention in a few places (such as biber).

Will pull in and test a bit, don't delay on my account but I'll hopefully report back with some positive news once in a $rebuild_completion_period or so. ⌚

@worldofpeace
Copy link
Contributor Author

Maybe that's unrelated to this change https://hydra.nixos.org/build/92065248

Yes, it was broken in April but already fixed in #60861

This pr clearly doesn't have that commit 0a64e79.
Thinking maybe I should check if this is still an issue on staging then.

@worldofpeace
Copy link
Contributor Author

ping @volth . Any insights?

@worldofpeace
Copy link
Contributor Author

So from what you said this is an atypical issue and any anticipated regressions would be limited as it's limited already. 👍 Making it less of an unattractive "fix".

@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 22, 2019

Hmm and not having it causing issues for others right away dhbw-stginf16a/nosql-book#23 🤣

@matthewbauer
Copy link
Member

I am hoping we can also revert 5a5a597 with this

@FRidh
Copy link
Member

FRidh commented May 28, 2019

Can this go in?

@matthewbauer
Copy link
Member

Can this go in?

Perhaps just
75420af

to avoid mass-rebuild and possible affecting 1000+ of perlPackages
The rest of derivations (ddclient, po4a) are already fixed, so biber seems to be the only one which need hostPlatform's perl

Anything that installs a perl script that needs to be executed will need the host platform's perl. That should be a lot of scripts that it isn't worth patching these manually. We should revert those fixes.

@matthewbauer matthewbauer merged commit c441858 into NixOS:staging May 28, 2019
@worldofpeace worldofpeace deleted the fix-perl branch May 28, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants