kitty: 0.13.3 -> 0.14.0 #62095
Merged
kitty: 0.13.3 -> 0.14.0 #62095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
commented
May 26, 2019
| @@ -67,18 +67,6 @@ buildPythonApplication rec { | |||
| libstartup_notification = "${libstartup_notification}/lib/libstartup-notification-1.so"; | |||
| }) | |||
| ] ++ stdenv.lib.optionals stdenv.isDarwin [ | |||
| (fetchpatch { | |||
rvolosatovs
commented
May 26, 2019
| url = https://github.com/kovidgoyal/kitty/commit/af2c9a49b1ad31e94242295d88598591623fbf11.patch; | ||
| sha256 = "0k3dmgbvmh66j8k3h8dw6la6ma6f20fng6jjypy982kxvracsnl5"; | ||
| }) | ||
| ./macos-10.11.patch |
There was a problem hiding this comment.
this change was merged in kovidgoyal/kitty#1430
There was a problem hiding this comment.
This change was not merged. The pull request was rejected because kovidgoyal is not interested in providing support for more than 2-3 macOS versions. But I don't think anyone complained about this being broken on macOS 10.11 (I could be wrong though).
There was a problem hiding this comment.
Yes, I thought this was strange too. Anyway, we did an upgrade to 10.12 SDK, so the patch was to be removed.
ryantm
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream update
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)