Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kvmgt: fix starting condition #62096

Merged
merged 1 commit into from Jun 17, 2019
Merged

nixos/kvmgt: fix starting condition #62096

merged 1 commit into from Jun 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2019 •
edited by ghost

Motivation for this change

Instead of #48640. I've asked on related mailing lists and systemd.path helper was the solution that worked https://www.freedesktop.org/software/systemd/man/systemd.path.html

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 16, 2019

Have you tested this? (since I don't see any check-marks).
Can this be tested with any modern Intel GPU?

@ghost
Copy link
Author

ghost commented Jun 16, 2019

@Mic92

Have you tested this? (since I don't see any check-marks).

It works

$ systemctl status kvmgt-i915-GVTg_V5_8
● kvmgt-i915-GVTg_V5_8.service - KVMGT VGPU i915-GVTg_V5_8
   Loaded: loaded (/nix/store/2ycqbzkrx7bmslykc258hnmyvi2r73a5-unit-kvmgt-i915-GVTg_V5_8.service/kvmgt-i915-GVTg_V5_8.service; linked; vendor preset: enabled)
   Active: active (exited) since Sun 2019-06-16 13:48:57 MSK; 1min 4s ago
  Process: 942 ExecStart=/nix/store/fyxcppddjg7abrand8n10gwzm5gknc48-bash-4.4-p23/bin/bash -c echo a297db4a-f4c2-11e6-90f6-d3b88d6c9525 > /sys/bus/pci/devices/0000:00:02.0/mdev_supported_types/i915-GVTg_V5_8/create (code=exited, status=0/>
 Main PID: 942 (code=exited, status=0/SUCCESS)

июн 16 13:48:57 nixos systemd[1]: Starting KVMGT VGPU i915-GVTg_V5_8...
июн 16 13:48:57 nixos systemd[1]: Started KVMGT VGPU i915-GVTg_V5_8.

Can this be tested with any modern Intel GPU?

I think using 5th to 7th generation. I'm not sure they upstreamed support for 8th+ generations. Perhaps using latest kernel. Here's an instruction https://nixos.wiki/wiki/IGVT-g

@Mic92 Mic92 merged commit 55e2c85 into NixOS:master Jun 17, 2019
@ghost
Copy link
Author

ghost commented Jun 17, 2019

@Mic92 Thank you!

@ghost ghost deleted the kvmgt branch June 17, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92