Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pylibgen: 2.0.1 -> 2.0.2 #66242

Merged
merged 2 commits into from Aug 17, 2019
Merged

python3Packages.pylibgen: 2.0.1 -> 2.0.2 #66242

merged 2 commits into from Aug 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 7, 2019 •
edited

Motivation for this change

noticed it was broken while reviewing one of my other PRs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nico202

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66242
2 package were build:
papis python37Packages.pylibgen

[nix-shell:~/.cache/nix-review/pr-66242]$ ./results/papis/bin/papis --help
Usage: papis [OPTIONS] COMMAND [ARGS]...

Options:
  -h, --help                      Show this message and exit.
...

@jonringer jonringer requested a review from FRidh as a code owner August 7, 2019 01:15
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build papis

worldofpeace
worldofpeace reviewed Aug 7, 2019
View reviewed changes
pkgs/development/python-modules/pylibgen/default.nix Outdated
@@ -19,7 +21,7 @@ buildPythonPackage rec {

checkInputs = [ pytest ];

# no tests in PyPI tarball
# too lazy to add pre-commit package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean, we have gitAndTools.pre-commit maybe you can use toPythonModule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a seperate pypi package with the same name. I was trying to go home and just wanted to push the progress. I guess i didn't have to open a pr... xD

@nico202
Copy link
Contributor

nico202 commented Aug 7, 2019

I'm moving from nix to guix, so if somebody wants to take the ownership of the package s/he's welcome

@jonringer
Copy link
Contributor Author

@nico202 unrelated to the PR, but I'm curious as to the motive behind moving to guix. Other than being able to use scheme and more of a focus on libre software, I'm not sure of a big difference.

@nico202
Copy link
Contributor

nico202 commented Aug 8, 2019

Well the focus on the libre software is an important issue for me. Also, if at first I had difficulties in writing packages in scheme, now I find it to be a better language (after years I was able to have julia packages almost working, I was not able to do the same in nix). Another thing that at first I thought was better in nix was nix-shell, but guix environment is way more powerful. Then, I don't think guix pack (create distributable tarballs) has something similar in the nix world. Lastly, being an emacs user, the emacs-guix interface is superior to nox or anything else. I'm really happy with guix, even if there are way less packages, package management is a slower and to send patches you need emails :D

@jonringer
Copy link
Contributor Author

@nico202 thanks for the response. Wish you the best :)

@worldofpeace
Copy link
Contributor

Were you going to address #66242 (comment) @jonringer?

@jonringer
Copy link
Contributor Author

yea, sorry, Keep getting distracted ;)

@jonringer jonringer force-pushed the fix-pylibgen branch 3 times, most recently from 8c3a5f5 to 5dc20b6 Compare August 9, 2019 19:26
@jonringer
Copy link
Contributor Author

@worldofpeace looks llike all the tests try to do a network call..... so it was all for not, trying to get tests working 🤣

@worldofpeace
Copy link
Contributor

@worldofpeace looks llike all the tests try to do a network call..... so it was all for not, trying to get tests working rofl

Aww. Sorry about that.

@jonringer
Copy link
Contributor Author

you couldn't have know, I couldn't have known :(

@jonringer jonringer force-pushed the fix-pylibgen branch 2 times, most recently from d955853 to 7e67bcd Compare August 9, 2019 21:55
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.pre-commit python3Packages.pre-commit python36Packages.pylibgen

@jonringer
Copy link
Contributor Author

moved the pre-commit package from being an application under git-and-tools, to a proper python packages (supports python{2.7,3.5,3.6,3.7} now), then used the "python3Packages.toPythonApplication" function to import it back under the git-and-tools namespace. Also added an alias for it under all-packages to the gitAndTools.pre-commit package.

pylibgen now builds with python3.{6,7}

@jonringer
Copy link
Contributor Author

@FRidh rebased off master, no more merge conflicts. Edited pre-commit message to now reflect that i moved the expression from gitAndTools to pythonPackages,

@FRidh FRidh merged commit 7055dee into NixOS:master Aug 17, 2019
@jonringer jonringer deleted the fix-pylibgen branch August 17, 2019 16:11
@jonringer jonringer mentioned this pull request Jun 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @nico202 @worldofpeace @FRidh