Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-bloat: 0.7.2 -> 0.8.2 #66256

Merged
merged 1 commit into from Aug 7, 2019
Merged

cargo-bloat: 0.7.2 -> 0.8.2 #66256

merged 1 commit into from Aug 7, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 7, 2019

Motivation for this change

Update cargo-bloat to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

Hey @xrelkd, with projects like this it's helpful to reviewers to post the changelog

@GrahamcOfBorg build cargo-bloat
(for macos since they added a feature)

@worldofpeace worldofpeace merged commit 0d4c5dc into NixOS:master Aug 7, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 8, 2019

@worldofpeace Thanks for the review. I will post the changelog the next time I create a PR.

@xrelkd xrelkd deleted the update/cargo-bloat branch August 8, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @worldofpeace