Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-sharp: mono4 -> mono5 #66255

Merged
merged 1 commit into from Aug 8, 2019
Merged

Conversation

jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Aug 7, 2019

Motivation for this change

Eliminate use of mono4 in gnome-sharp library.

Tested with

% nix-env -i gconf
nix-review ...
open some PDF in pdfmod, open tomboy

Both applications would segfault on close, but other than that seemed to work ok. Same result I got with version in 19.03 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@ofborg ofborg bot requested a review from vbgl August 7, 2019 07:51
@vbgl vbgl merged commit ee68421 into NixOS:master Aug 8, 2019
@jirkadanek jirkadanek deleted the jd_gnome-sharp_update_mono branch August 8, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants