Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.kubernetes: 9.0.0 -> 10.0.0 #66108

Merged
merged 1 commit into from Aug 7, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 5, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-kubernetes/versions.

meta.description for python37Packages.kubernetes is: '"Kubernetes python client"'.

meta.homepage for python37Packages.kubernetes is: '"https://github.com/kubernetes-client/python"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.kubernetes
python37Packages.kubernetes
python37Packages.rl-coach

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fv3yxqzkk5fkx742362qqh68fc0001c6-python3.7-kubernetes-10.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A python37Packages.kubernetes https://github.com/r-ryantm/nixpkgs/archive/6acaa3395f0ae4a305e3e26fd6239805c432581e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fv3yxqzkk5fkx742362qqh68fc0001c6-python3.7-kubernetes-10.0.0
ls -la /nix/store/fv3yxqzkk5fkx742362qqh68fc0001c6-python3.7-kubernetes-10.0.0/bin

cc @lsix for testing.

@lsix
Copy link
Member

lsix commented Aug 6, 2019

nox-review pr works fine.

As far as I can tell, there is API breaking changes and it might break python3Packages.rl-coach (only derivation de directly depend on it).

@timokau can you check if rl-coach is fine with the python kubernetes client update ? You unpinned the kubernetes version (https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/rl-coach/default.nix#L78-L80). It does not seem that this binding is a fundamental requirement.

I am waiting for you to give me a green light before I merge this one.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still pass and basic manual testing (coach -r -p CartPole_PG) reveals no issues. Fine by me 👍

@ryantm ryantm merged commit 541690a into NixOS:master Aug 7, 2019
@r-ryantm r-ryantm deleted the auto-update/python3.7-kubernetes branch August 17, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants