Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cht.sh: unstable-2018-11-02 -> unstable-2019-08-06 #66237

Merged
merged 2 commits into from Aug 8, 2019
Merged

cht.sh: unstable-2018-11-02 -> unstable-2019-08-06 #66237

merged 2 commits into from Aug 8, 2019

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Aug 6, 2019

Motivation for this change

Discovered cht.sh but then realized the CLI doesn't have shell completions in the version available on nixpkgs.
They're sort of helpful when you get past 1,000 options.

Closure size:

/nix/store/plz5ab1xlgp1gkv26y3skrbf27w5ka26-cht.sh-unstable-2018-11-02     45469952
/nix/store/vy2xm234qaizjy1iz4p4xc08sp4v3bn5-cht.sh-unstable-2019-08-06     45481360
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fgaz

@evanjs
cht.sh: unstable-2018-11-02 -> unstable-2019-08-06
9037a5a 
- Bump cht.sh to unstable-2019-08-06
- Add bash and zsh completions
@evanjs
Add evanjs to maintainers
1632c09 
- Add evanjs to maintainer list
- Add evanjs to maintainers for cht.sh
@srhb srhb merged commit 8c588e6 into NixOS:master Aug 8, 2019
@evanjs evanjs deleted the feature/cht.sh-unstable-2019-08-06 branch August 8, 2019 19:21
@fgaz
Copy link
Member

fgaz commented Aug 11, 2019

Thanks for helping maintain the package

@evanjs
Copy link
Member Author

evanjs commented Aug 11, 2019 •
edited

Thanks for helping maintain the package

Don't mention it!
Discovered this package via Reddit and noticed we didn't have tab completions and I knew I had to have it.

Better yet, it seems like @chubin is okay opening issues here after major updates, etc 🎉 (context)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @fgaz @srhb