Reorganize GNOME tests, re-enable LightDM for release-combined #66236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
force-pushed
the
test-reorganize
branch
from
e80d444
to
c820ed8
Compare
Thoughts for followup improvement
|
worldofpeace
force-pushed
the
test-reorganize
branch
2 times, most recently
from
976712d
to
35928e3
Compare
The actual only difference from the gnome3-xorg test is that this tests the wayland session. It's also more accurate to call it just "gnome3" since wayland is default here.
We should be ensuring that this session functions as well because it's default.
This has been tested in the Pantheon test for a year now and it does fine on hydra.
worldofpeace
force-pushed
the
test-reorganize
branch
from
35928e3
to
89cd2b7
Compare
|
For some reason I couldn't get the |
worldofpeace
force-pushed
the
test-reorganize
branch
2 times, most recently
from
2b733a3
to
4ff4450
Compare
worldofpeace
force-pushed
the
test-reorganize
branch
from
bb0044e
to
4aedbb4
Compare
|
@GrahamcOfBorg test gnome3 |
ofborg
bot
added
the
6.topic: GNOME
jtojnar
reviewed
Aug 7, 2019
| ]; | ||
|
|
||
| mesonFlags = [ | ||
| "-Dubuntu_reviews=false" | ||
| "-Dgudev=false" | ||
| ] ++ stdenv.lib.optionals (!withFwupd) [ | ||
| "-Dfwupd=false" |
There was a problem hiding this comment.
Why this? Should not fwupd now build on aarch64?
There was a problem hiding this comment.
I only pushed this so I could see if it would build on the aarch64 builder, or there wasn't other things broken. Currently building fwupd needs ghc which samueldr informed my was broken for him.
jtojnar
reviewed
Aug 7, 2019
| @@ -1,7 +1,7 @@ | |||
| import ./make-test.nix ({ pkgs, ...} : { | |||
| name = "gnome3-xorg"; | |||
| meta = with pkgs.stdenv.lib.maintainers; { | |||
| maintainers = [ domenkozar eelco lethalman ]; | |||
| maintainers = pkgs.gnome3.maintainers; | |||
There was a problem hiding this comment.
Should we remove Eelco and Domen here?
There was a problem hiding this comment.
Have they contributed to the test in the past year? Would they be responsive to pings to fix and review it?
Needed temporarily because of NixOS#66277.
worldofpeace
force-pushed
the
test-reorganize
branch
from
137aed7
to
5cad152
Compare
worldofpeace
force-pushed
the
test-reorganize
branch
from
5cad152
to
45643ba
Compare
|
I've tested that everything succeeds on aarch64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Other than the name changes
all the GNOME3 tests use GDM andwe re-enabled the LightDM testand GNOME and Pantheons tests are enabled for all platforms.
Things done
quick hack, haven't tested anything yetsandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @