Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vulkan packages #66238

Merged
merged 4 commits into from Aug 31, 2019
Merged

Update vulkan packages #66238

merged 4 commits into from Aug 31, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 6, 2019

Motivation for this change

saw rryantm was trying to update a vulkan package, closes #66178 :)

Actions:

  • updated the vulkan-* to latest sdk/version release.
    • Removed search path patch, as the upstream package added one
  • updated glslang to latest release
    • fixed typo in override
  • updated spirv-headers to use latest release (instead of inheriting spriv-tools version)
    • this is okay as long as header is more up-to-date than spirv-tools
  • updated spirv-tools
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ralith

closes #66178

airwave seems to be broken on master, investigating libretro.mame

[521 built (2 failed), 836 copied (7744.7 MiB), 1798.9 MiB DL]
error: build of '/nix/store/m1hvd3jy8h3pf3mnpbcsvk570xr7m5id-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66238
2 package failed to build:
airwave libretro.mame

71 package were build:
curseradio deepin.dde-file-manager deepin.deepin-movie-reborn dolphinEmuMaster glslang gnome-mpv kodiPlugins.steam-launcher libretro._4do libretro.beetle-pce-fast libretro.beetle-psx libretro.beetle-saturn libretro.bsnes-mercury libretro.desmume libretro.dolphin libretro.fba libretro.fceumm libretro.gambatte libretro.genesis-plus-gx libretro.higan-sfc libretro.mgba libretro.mupen64plus libretro.nestopia libretro.parallel-n64 libretro.picodrive libretro.ppsspp libretro.prboom libretro.quicknes libretro.reicast libretro.scummvm libretro.snes9x libretro.snes9x-next libretro.stella libretro.vba-m libretro.vba-next linux-steam-integration lutris lutris-free lutris-unwrapped mpc-qt mpv mpv-with-scripts pipelight playonlinux plex-media-player python27Packages.mpv python37Packages.mpv renderdoc retroarch retroarchBare rpcs3 spirv-headers spirv-tools steam steam-run steam-run-native steamcmd vkquake vulkan-headers vulkan-loader vulkan-tools vulkan-validation-layers wine wineStaging wineStable winePackages.staging wineUnstable wineWowPackages.base wineWowPackages.full wineWowPackages.staging wineWowPackages.unstable winetricks

name = "spirv-headers-${version}";
version = "2019.1"; # spirv-tools version whose DEPS file calls for this commit
pname = "spirv-headers";
version = "1.4.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is okay as long as header is more up-to-date than spirv-tools

Where is this guarantee made?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LunarG seem to be adhering to SemVer, as long as a major version isn't publish, it should be compatible.

It's about the vulkan-headers, but I think it's still relevant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIRV-Headers is a different project developed by different people. Given that SPIRV-Tools goes out of its way to identify a specific commit that it relies on, not just a version number, I don't think we should presume to know better without an explicit guarantee from the maintainers.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@jonringer what is the status on this one?

@jonringer
Copy link
Contributor Author

I can check for another version bump, but it should be good. I'll have to do more in-depth testing later

@aanderse
Copy link
Member

Looks reasonable. Trusting @jonringer on adequate testing, etc... 😄 Thanks! 🎉

@aanderse aanderse merged commit 6951cbe into NixOS:master Aug 31, 2019
@jonringer jonringer deleted the update-vulkan branch August 31, 2019 15:57
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 10, 2020
Update vulkan packages

(cherry picked from commit 6951cbe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants