New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vulkan packages #66238
Update vulkan packages #66238
Conversation
name = "spirv-headers-${version}"; | ||
version = "2019.1"; # spirv-tools version whose DEPS file calls for this commit | ||
pname = "spirv-headers"; | ||
version = "1.4.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is okay as long as header is more up-to-date than spirv-tools
Where is this guarantee made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LunarG seem to be adhering to SemVer, as long as a major version isn't publish, it should be compatible.
It's about the vulkan-headers, but I think it's still relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPIRV-Headers is a different project developed by different people. Given that SPIRV-Tools goes out of its way to identify a specific commit that it relies on, not just a version number, I don't think we should presume to know better without an explicit guarantee from the maintainers.
6949e4e
to
96a64ff
Compare
@jonringer what is the status on this one? |
I can check for another version bump, but it should be good. I'll have to do more in-depth testing later |
Looks reasonable. Trusting @jonringer on adequate testing, etc... 😄 Thanks! 🎉 |
Update vulkan packages (cherry picked from commit 6951cbe)
Motivation for this change
saw rryantm was trying to update a vulkan package, closes #66178 :)
Actions:
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @Ralith
closes #66178
airwave seems to be broken on master, investigating libretro.mame