Add support for cmt (Chromium Multitouch drivers), custom drivers for chromebooks. #66195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Aug 9, 2019
| default = false; | ||
| description = "Enable custom touchpad for selected model"; | ||
| }; | ||
| banjo = mkOption { |
There was a problem hiding this comment.
This is not good, there shouldn't be a separate option for every possible model. Instead I suggest to have a single option like this:
{
models = mkOption {
type = types.enum [ "atlas" "banjo" ... ];
default = [];
example = [ "banjo" ];
description = "Which models to enable cmt for.";
};
}
Or maybe even not have an option at all and always enable all of them, I don't see any disadvantage of doing that
| enable = mkOption { | ||
| type = types.bool; | ||
| default = false; | ||
| description = "Enable chrome multitouch input (cmt). Touchpad drivers that are configured for chromebooks"; |
There was a problem hiding this comment.
Put a . at the end of descriptions
| meta = { | ||
| description = "Chromebook touchpad driver"; | ||
| license = stdenv.lib.licenses.mit; | ||
| platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
Homepage and maintainer fields are missing
|
|
||
|
|
||
| makeFlags = [ "DESTDIR=$(out)" "LIBDIR=/lib" ]; | ||
| } |
There was a problem hiding this comment.
meta missing completely, in libevdevc as well
| @@ -0,0 +1,34 @@ | |||
| { stdenv, fetchFromGitHub, pkgconfig, xorgserver, xorgproto, | |||
| utilmacros, libgestures, libevdevc, chromium-xorg-conf }: | |||
There was a problem hiding this comment.
chromium-xorg-conf is never used
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add support for custom Chromebook drivers.
Things done
Added following cmt dependencies to pkgs: libgestures, libevdevc, and chromium-xorg-conf to pkgs
Added cmt.nix to nixpkgs/nixos/modules/servers/x11/hardware/
Known bug: Can't adjust acceleration or sensitivity from system touchpad settings (tested on samus).
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @yegortimoshenko