Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hostname in tests overridable #66257

Merged
merged 1 commit into from Aug 7, 2019
Merged

Make hostname in tests overridable #66257

merged 1 commit into from Aug 7, 2019

Conversation

knl
Copy link
Contributor

@knl knl commented Aug 7, 2019

The original form effectively forbade any NixOS configuration that is under
test to explicitly set the hostname.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@knl
Make hostname in tests overridable
d0ef942 
The original form effectively forbade any NixOS configuration that is under
test to explicitly set the hostname.
@ofborg ofborg bot added the 6.topic: nixos label Aug 7, 2019
@basvandijk
Copy link
Member

LGTM.

Just executing one test that uses networking.hostName to make sure this doesn't break anything:

@GrahamcOfBorg test mysqlReplication

@basvandijk
Copy link
Member

Unfortunately mysqlReplication fails because of an unrelated error (it also fails on master). Trying another test:

@GrahamcOfBorg test proxy

@basvandijk basvandijk merged commit 69c7aee into NixOS:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knl @basvandijk