Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexibee: init at 2019.2.5 #66258

Merged
merged 1 commit into from Aug 7, 2019
Merged

flexibee: init at 2019.2.5 #66258

merged 1 commit into from Aug 7, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 7, 2019

Motivation for this change

flexibee: init at 2019.2.5

I had to move the share content directly into the root path, as these seems to be harded directly into the jar file itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things I how you'll find helpful.

pkgs/applications/office/flexibee/default.nix Show resolved Hide resolved
pkgs/applications/office/flexibee/default.nix Show resolved Hide resolved
pkgs/applications/office/flexibee/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/flexibee/default.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member

prusnak commented Aug 7, 2019

I built the binary on NixOS and tried running it. It worked 👍

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmahut and @prusnak!

@aanderse aanderse merged commit 06408a6 into NixOS:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants