Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: add missing arguments to emulateApp function #66319

Closed
wants to merge 1 commit into from

Conversation

markus1189
Copy link
Contributor

Motivation for this change

The emulateApp function in androidenv was missing some arguments, that are subsequently passed to composeAndroidPackages.

I added:

  • includeExtras
  • platformToolsVersion
  • emulatorVersion

Also the useGoogleAPIs argument was there, but not used, so I fixed that as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @svanderburg

@markus1189
Copy link
Contributor Author

Fixed conflicts

@markus1189
Copy link
Contributor Author

Closing this due to inactivity

@markus1189 markus1189 closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant