Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino: fix incorrect sha256 in Darwin build #66216

Merged
merged 1 commit into from Aug 7, 2019
Merged

arduino: fix incorrect sha256 in Darwin build #66216

merged 1 commit into from Aug 7, 2019

Conversation

gazally
Copy link
Contributor

@gazally gazally commented Aug 6, 2019

Motivation for this change

Fix #66176

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @antono @auntie @robberer @bjornfor

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Aug 6, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build arduino

@worldofpeace
Copy link
Contributor

It appears arduino wouldn't evaluate on darwin.

@truh
Copy link
Member

truh commented Aug 7, 2019

@gazally I tested it with nix-build -A arduino . --show-trace on Darwin. It reports:

error: while evaluating the attribute 'arduino_dist_src' of the derivation 'arduino-1.8.5' at /Users/jakob/Repos/NixOS/nixpkgs/pkgs/development/arduino/arduino-core/default.nix:62:3:
while evaluating the attribute 'outputHash' of the derivation 'arduino-1.8.5-.tar.xz' at /Users/jakob/Repos/NixOS/nixpkgs/pkgs/build-support/fetchurl/default.nix:119:3:
fetchurl requires a hash for fixed-output derivation: http://downloads.arduino.cc/arduino-1.8.5-.tar.xz

@Mic92 Mic92 merged commit 7ccfefe into NixOS:master Aug 7, 2019
@Mic92
Copy link
Member

Mic92 commented Aug 7, 2019

At least the checksum is correct now. The evaluation issue can be resolved in a different PR.

@gazally gazally deleted the arduino-darwin-fix branch August 8, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arduino: fails to build
4 participants
@gazally @worldofpeace @truh @Mic92