Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.tensorflow: fix hash for gpu build #66219

Closed
wants to merge 2 commits into from

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Aug 6, 2019

Motivation for this change

Old hash no longer builds for me. Hydra will not build python37Packages.tensorflowWithCuda because it's unfree.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@@ -267,7 +267,7 @@ let

# cudaSupport causes fetch of ncclArchive, resulting in different hashes
sha256 = if cudaSupport then
"1rbzvir569ch33bpvm47byx954vr80rjnzrbgs4rg3bqww73hr3k"
"1dpfyagcx1p4vzfabsl9v5i75332vv2mhk90897i75k6ciq292qs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a different hash :(

hash mismatch in fixed-output derivation '/nix/store/khcwjcxv7l1w2n5w4rxipj0qrpqqy0ma-tensorflow-gpu-1.14.0-deps':
  wanted: sha256:1dpfyagcx1p4vzfabsl9v5i75332vv2mhk90897i75k6ciq292qs
  got:    sha256:1jrf5m1daazwawgvlv0z21qyf1l5aa4l19bfh961pll325xrh76h
cannot build derivation '/nix/store/rc1jhdpgd0wckwqmh5javig2cca419yr-tensorflow-gpu-1.14.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/djpai7nalflmdmx5cry9z1wizb30ivbg-python3.7-tensorflow-gpu-1.14.0.drv': 1 dependencies couldn't be built
Suggested change
"1dpfyagcx1p4vzfabsl9v5i75332vv2mhk90897i75k6ciq292qs"
"1jrf5m1daazwawgvlv0z21qyf1l5aa4l19bfh961pll325xrh76h"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, i confirmed that python3Packages.tensorflowWithCuda doesn't build on master

Loading: 446 packages loaded
installing
error: getting attributes of path '/nix/store/khcwjcxv7l1w2n5w4rxipj0qrpqqy0ma-tensorflow-gpu-1.14.0-deps/aws/aws-cpp-sdk-acm/include/aws/acm/model/Tag.h': No such file or directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now I also get the same hash as you do, maybe it's updated a lot or impure. Also,
-r--r--r-- 1 root root 3413 Jan 1 1970 /nix/store/khcwjcxv7l1w2n5w4rxipj0qrpqqy0ma-tensorflow-gpu-1.14.0-deps/aws/aws-cpp-sdk-acm/include/aws/acm/model/Tag.h
so maybe you ran out of disk-space or something? Either way it seems this is not a stable hash. We could commit it now, or close, but it'll probably break again I guess.
People who need it can still go with tensorflow-bin so it's probably not urgent.

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@abbradar
Copy link
Member

abbradar commented Aug 9, 2019

Ugh, ugly. I'll investigate; I hoped that after #65374 things would be better but no dice...

@abbradar
Copy link
Member

Fixed in 3b3618e

Sometimes when I feel desperate I come to the conclusion that Google just hates us and deliberately places quirks in their builds to make them as non-deterministic as possible. I know that's just my growing paranoia but maybe, just maybe...

@abbradar abbradar closed this Aug 19, 2019
@averelld averelld deleted the tf-gpu-hashes branch August 31, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants