Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flent: 1.2.2 -> 1.3.0 #66323

Merged
merged 4 commits into from Aug 31, 2019
Merged

flent: 1.2.2 -> 1.3.0 #66323

merged 4 commits into from Aug 31, 2019

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Aug 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmlb mmlb changed the title WIP flent: 1.2.2 -> 1.3.0 flent: 1.2.2 -> 1.3.0 Aug 8, 2019
@markus1189
Copy link
Contributor

Note: never used flent before.

I played around with it locally using the gui. Seems to work fine, although for e.g. the `bursts1 test I get

19:54:27 ERROR: Runner Ping (ms) UDP EF failed check: No netperf binary found in PATH.

But I guess it's better to rely on netperf on the path instead of adding all tools for all tests (don't know how many there are) as a dependency

@mmlb
Copy link
Contributor Author

mmlb commented Aug 8, 2019

Yep, I had not added the dependencies when I created the package as I was only looking for the gui aspect of it, but that should probably be changed. @teto took a stab at wrapping flent, though #41521 I'm not quite sure what the ultimate goal was though.

@teto
Copy link
Member

teto commented Aug 9, 2019

let's provide a full version by default then. Pass an extraPrograms ? [ ] parameter and from all-packages.nix pass the required 3rd party programs: iperf/netperf etc.
It's not like these are huge programs anyway. Would be good to see the change in closure size though.

@mmlb
Copy link
Contributor Author

mmlb commented Aug 12, 2019

@teto sgtm, but in a follow up PR?

@aanderse aanderse requested a review from teto August 31, 2019 02:00
@teto teto merged commit 8136744 into NixOS:master Aug 31, 2019
@teto
Copy link
Member

teto commented Aug 31, 2019

waiting for the follow up commit then, let's build with everything but let the possibility for someone to srip it down, sthg like extraDeps ? [ netperf iperf ... ]

@mmlb
Copy link
Contributor Author

mmlb commented Sep 5, 2019

sgtm, will do so in next few days.

@mmlb mmlb deleted the update-flent branch October 13, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants