Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chicken: fixes for chicken 5.1.0 #66245

Merged
merged 1 commit into from Aug 15, 2019
Merged

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Aug 7, 2019

  • fix incorrect binaryVersion
  • upgrade chicken-5 eggs
  • fix repository path
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- fix incorrect binaryVersion
- upgrade chicken-5 eggs
- fix repository path
@corngood
Copy link
Contributor Author

corngood commented Aug 7, 2019

This fixes a few problems introduced by ba189ee. chicken itself has built since then, but is mostly broken, and egg2nix doesn't build.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build chicken

@joachifm joachifm merged commit e8c04bb into NixOS:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants