Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 4.1.6 -> 4.1.7 #66246

Merged
merged 1 commit into from Aug 7, 2019
Merged

qbittorrent: 4.1.6 -> 4.1.7 #66246

merged 1 commit into from Aug 7, 2019

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Upgrade qbittorrent to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Anton-Latukha

@ivan
Copy link
Member

ivan commented Aug 7, 2019

@GrahamcOfBorg build qbittorrent

ivan
ivan approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested on x86_64 NixOS, everything seems to be working fine.

Anton-Latukha
Anton-Latukha approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@Anton-Latukha Anton-Latukha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mmahut mmahut merged commit 2242527 into NixOS:master Aug 7, 2019
@kira-bruneau kira-bruneau deleted the qbittorrent branch August 7, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@Anton-Latukha Anton-Latukha Anton-Latukha approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kira-bruneau @ivan @Anton-Latukha @mmahut