Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tendermint: init at 0.32.2 #66306

Merged
merged 1 commit into from Aug 8, 2019
Merged

tendermint: init at 0.32.2 #66306

merged 1 commit into from Aug 8, 2019

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Aug 8, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alexfmpe alexfmpe mentioned this pull request Aug 8, 2019
Closed
@ofborg ofborg bot requested a review from kalbasit August 8, 2019 03:02
@markus1189
Copy link
Contributor

markus1189 commented Aug 8, 2019 •
edited

Works fine for me and did the single node tutorial add https://tendermint.com/docs/introduction/quick-start.html#local-node

 - system: `"x86_64-linux"`
 - host os: `Linux 5.2.2, NixOS, 19.09pre187917.ac95de0d2ea (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.2.2`
 - channels(root): `"nixos-19.09pre187917.ac95de0d2ea"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@marsam marsam merged commit c2cc6aa into NixOS:master Aug 8, 2019
@marsam
Copy link
Contributor

marsam commented Aug 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfmpe @markus1189 @marsam