Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: use ld.gold only on Linux #66310

Merged
merged 1 commit into from Aug 8, 2019
Merged

ghc: use ld.gold only on Linux #66310

merged 1 commit into from Aug 8, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 8, 2019

Motivation for this change

Fixes #66221
partly reverts commit 29f2f04.

from @matthewbauer comment:

Yeah, gold should only be used on Linux (it might work on other ELF-based systems too). gold is also in a weird place with Google kind of abandoning it in favor of lld.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
ghc: use ld.gold only on Linux
639c8c1 
partly reverts commit 29f2f04.
@marsam marsam requested a review from basvandijk as a code owner August 8, 2019 03:11
@ofborg ofborg bot requested review from kosmikus and peti August 8, 2019 03:24
@vcunat
Copy link
Member

vcunat commented Aug 8, 2019

Have you/someone verified that this really does fix the darwin build? (It's probably too big for @GrahamcOfBorg.)

@vcunat
Copy link
Member

vcunat commented Aug 8, 2019

Well, let me try anyway :-)
@GrahamcOfBorg build ghc

vcunat
vcunat approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, a binary cache hit on darwin :-) I thought we couldn't get that due to some (other) changes in the meantime. Well, I can't see why wait.

@vcunat vcunat merged commit 639c8c1 into NixOS:master Aug 8, 2019
vcunat added a commit that referenced this pull request Aug 8, 2019
@vcunat
Merge #66310: ghc: use ld.gold only on Linux
83fdb5f
@marsam marsam deleted the fix-ghc-darwin branch August 8, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@kosmikus kosmikus Awaiting requested review from kosmikus

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHC 8.6.5 does not build on Darwin
2 participants
@marsam @vcunat