[19.03] nixos-containers: add TimeoutStartSec option #66205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked work-in-progress to signal that the PR this backports hasn't been approved and merged to master. |
davidak
force-pushed
the
backport_nixos-containers-TimeoutStartSec
branch
from
64036f0
to
cc26704
Compare
davidak
force-pushed
the
backport_nixos-containers-TimeoutStartSec
branch
from
cc26704
to
e1a1969
Compare
|
It has now been approved and merged to master. I updated this branch and run the tests. |
Default is now 1m instead of global default of 15sec. It is also configurable. Fixes issue where start of many containers (40+) fail NixOS#65001 (cherry picked from commit eba686d) Reason: Problem exists in stable too
davidak
force-pushed
the
backport_nixos-containers-TimeoutStartSec
branch
from
e1a1969
to
6a04061
Compare
|
@infinisil can you review and merge this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport #65661 to fix #65001 on stable too!
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @