@worldofpeace Any chance you can merge this? Or point me to an appropriate person to ping? Thanks!

I don't know what happened to this thread, but I can't read it.

I'll try responding like this:

This doesn't work. It fails in "unpacking sources" phase, since no directory is actually created.

You need to do

sourceRoot= ".";

Whatever got unpacked should be in the $CWD for you to copy into $out

I don't follow. Please explain?

I mean cp ucm $out/bin

This is a binary package so it needs to be patched.
You should be able to do this by adding autoPatchelfHook to nativeBuildInputs.

I don't really understand what this is. What needs to be patched? Can you explain @worldofpeace ? Thanks!

https://nixos.wiki/wiki/Packaging/Binaries explains this very well.
Simply put the binary ucm won't work on NixOS without hardcoding libraries to runtime search path of the executable etc. You probably didn't notice this because this binary would work on MacOS by default.

By doing

You should be able to do this by adding autoPatchelfHook to nativeBuildInputs.

it should take care of this for you completely, no need to patch it manually.

Not sure what you'd prefer to see here. This software is called ucm, and it is (description) the Unison Codebase Manager. What do you recommend i put here?

I got this from their github
"Modern, statically-typed purely functional language"

I don't know what happened to this thread, but I can't read it.

I'm sure i messed it up somehow, but not sure how. Sorry :(

I'll try responding like this:

This doesn't work. It fails in "unpacking sources" phase, since no directory is actually created.

You need to do

sourceRoot= ".";

Whatever got unpacked should be in the $CWD for you to copy into $out

I don't follow. Please explain?

I mean cp ucm $out/bin

Gotcha. This (and adding an unpackPhase to the list) together worked.

This is a binary package so it needs to be patched.
You should be able to do this by adding autoPatchelfHook to nativeBuildInputs.

I don't really understand what this is. What needs to be patched? Can you explain @worldofpeace ? Thanks!

https://nixos.wiki/wiki/Packaging/Binaries explains this very well.
Simply put the binary ucm won't work on NixOS without hardcoding libraries to runtime search path of the executable etc. You probably didn't notice this because this binary would work on MacOS by default.

Oh interesting. Yeah, i hadn't noticed this. Fixed!

By doing

You should be able to do this by adding autoPatchelfHook to nativeBuildInputs.

it should take care of this for you completely, no need to patch it manually.

Not sure what you'd prefer to see here. This software is called ucm, and it is (description) the Unison Codebase Manager. What do you recommend i put here?

I got this from their github
"Modern, statically-typed purely functional language"

Updated!

OK, i think i've made all the requested changes. It still works on my mac system, at least. :)

I'm sure i messed it up somehow, but not sure how. Sorry :(

I actually think GitHub had something to do with this.

@worldofpeace
Is there any other changes you think i should make?

Thanks again for taking the time to review this!

Can you change the description to just?
"Modern, statically-typed purely functional language"

It appears you've intersected two of them, and it seems like a lot of adjectives.

And I don't think we should use whitespace between the meta attributes.

Lastly, it fails to build on NixOS because of missing dependencies

libz.so.1 -> not found!
libtinfo.so.5 -> not found!
libgmp.so.10 -> not found!

so you need

• zlib
• ncurses
• gpm

Can you change the description to just?
"Modern, statically-typed purely functional language"

It appears you've intersected two of them, and it seems like a lot of adjectives.

Done!

And I don't think we should use whitespace between the meta attributes.

Done!

Lastly, it fails to build on NixOS because of missing dependencies

libz.so.1 -> not found!
libtinfo.so.5 -> not found!
libgmp.so.10 -> not found!

so you need

• zlib
• ncurses
• gpm

Hmm, i guess this makes sense for nixos. Shared libraries need to be declared, right?
I've added the runtime dependencies.

Done!

Hmm, i guess this makes sense for nixos. Shared libraries need to be declared, right?
I've added the runtime dependencies.

That output is from autoPatchelfHook and since you've built it on MacOS without sandboxing it probably found those shared libraries from the system.

@GrahamcOfBorg build unison-ucm

It looks like I've forgotten that obviously you don't need to patch binaries like this for darwin, and I miss suggested gpm when I meant gmp which is what haskell use's for multiple precision arithmetic.

Thanks for contributing @virusdave ✨
The above issue I fixed in the force push.

Thanks for the review @worldofpeace and your patience with me. This is my first "full package derivation" experience, and although it was simple (binary distro even), it was useful learning experience and i appreciate the help :)

Thanks for the review @worldofpeace and your patience with me. This is my first "full package derivation" experience, and although it was simple (binary distro even), it was useful learning experience and i appreciate the help :)

I'm happy to hear this 🌸 .
I like to think the nix manual's are helpful but there's nothing like the people behind them that write them. Always be prepared to learn something new from the people that are here ✨