Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dpdk update and dpdk 17.11 lts init #66250

Merged
merged 3 commits into from Oct 15, 2019
Merged

dpdk update and dpdk 17.11 lts init #66250

merged 3 commits into from Oct 15, 2019

Conversation

magenbluten
Copy link
Contributor

update dpdk to the current version. in order to not break the odp-dpdk package an aditional dpdk_17_11 package was introduced.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abuibrahim @Lassulus

@magenbluten magenbluten changed the title Dpdk dpdk update and dpdk 17.11 lts init Aug 7, 2019
@ofborg ofborg bot requested a review from domenkozar August 7, 2019 12:07
@Lassulus
Copy link
Member

Lassulus commented Oct 2, 2019

whupps, please rebase

@Lassulus
Copy link
Member

error with nix-review:

~/src/nixpkgs nix-review pr 66250
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/66250/head:refs/nix-review/1
$ git worktree add /home/lass/.cache/nix-review/pr-66250-1/nixpkgs 8040e5c13b7dbf65c8fc9b55330ed96dc91175f1
Preparing worktree (detached HEAD 8040e5c13b7)
Updating files: 100% (20022/20022), done.
HEAD is now at 8040e5c13b7 Merge pull request #71168 from mmahut/jormungandr
$ nix-env -f /home/lass/.cache/nix-review/pr-66250-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit d2aad0d1289a6dcc6db92365b736059ef6ed9ad3
Updating 8040e5c13b7..d2aad0d1289
Fast-forward
 pkgs/os-specific/linux/dpdk/default.nix     |  6 +++---
 pkgs/os-specific/linux/odp-dpdk/default.nix | 20 ++++++++++++++------
 pkgs/os-specific/linux/pktgen/default.nix   | 32 ++++++++------------------------
 3 files changed, 25 insertions(+), 33 deletions(-)
$ nix-env -f /home/lass/.cache/nix-review/pr-66250-1/nixpkgs -qaP --xml --out-path --show-trace --meta
error: while evaluating the attribute 'odp-dpdk' at /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/pkgs/top-level/all-packages.nix:16424:3:
while evaluating 'callPackageWith' at /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/lib/customisation.nix:108:35, called from /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/pkgs/top-level/all-packages.nix:16424:14:
while evaluating 'makeOverridable' at /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/lib/customisation.nix:67:24, called from /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/lib/customisation.nix:112:8:
undefined variable 'pname' at /home/lass/.cache/nix-review/pr-66250-1/nixpkgs/pkgs/os-specific/linux/odp-dpdk/default.nix:18:63

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2019

Can update SPDK as well? It needs to be in sync with DPDK afaik.

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2019

Nevermind it still built with the current version.

@Mic92 Mic92 merged commit 1f42959 into NixOS:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magenbluten @Lassulus @Mic92