tortoisehg: untie from mercurial and update to 5.0.2 #66173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I've added `tortoisehg` package, it turned out that mercurial updates sometimes broke thg. I've added a comment to `mercurial/default.nix` to update torotisehg version during mercurial updates, but this worked the other way round: mercurial stopped to be updated regularly (NixOS#60993). And sadly it didn't solve the issue - NixOS#61759. Here I'm trying to untie them. Tortoisehg will build a custom mercurial package if versions don't match. This makes updating tortoisehg more complicated, but it is still better than current situation.
|
@danbst I unfortunately don't have a good suggestion for how to make this work with nixpkgs-update right now. I opened an issue to track handling this kind of thing ryantm/nixpkgs-update#124 |
|
I'll sacrifice bot upgrades for now. The stability of thg and easier to upgrade mercurial is more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I've added
tortoisehgpackage, it turned out that mercurial updatessometimes broke thg. I've added a comment to
mercurial/default.nixtoupdate torotisehg version during mercurial updates, but this worked the other way round:
mercurial stopped to be updated regularly (#60993).
And sadly it didn't solve the issue - #61759.
Here I'm trying to untie them. Tortoisehg will build a custom mercurial package
if versions don't match. This makes updating tortoisehg more complicated,
but it is still better than current situation.
Fixes #66164
Unbreaks #60993 (which is probably outdated now)
Needs backport to 19.03 for #61759
cc @ryantm: I think bot updates will work for mercurial, but will break for
tortoisehg. What can I do to fix that?