Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmatrix: 1.2a -> 2.0 #66175

Merged
merged 1 commit into from Aug 6, 2019
Merged

cmatrix: 1.2a -> 2.0 #66175

merged 1 commit into from Aug 6, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 6, 2019 •
edited

Motivation for this change

fixing packages rryantm can't update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AndersonTorres

@teto
Copy link
Member

teto commented Aug 6, 2019

nix-review and binary work here.

@ofborg ofborg bot requested a review from AndersonTorres August 6, 2019 08:36
@teto teto merged commit 72e926a into NixOS:master Aug 6, 2019
@jonringer jonringer deleted the bump-cmatrix branch August 8, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @teto