Fix: saving crash.sav when disconnected from network game #7684
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an assertion failure created by the scenario outlined here: OpenTTD#6598 (comment) When a client gets disconnected from a network game that has an AI, and then crashes, it tries to write a crash.sav. Attempting to save the AI instance here, which doesn't exist on the client, causes the assertion failure. This change allows openttd to crash properly in this awkward scenario :P crash.sav and crash.png are now written: Writing crash log to disk... Crash log written to /home/nik/.openttd/crash.log. Please add this file to any bug reports. Writing crash savegame... Crash savegame written to /home/nik/.openttd/crash.sav. Please add this file and the last (auto)save to any bug reports. Writing crash screenshot... Crash screenshot written to /home/nik/.openttd/crash.png. Please add this file to any bug reports. Aborted
|
From the surrounding code it seems the |
|
Hmmm, yeah. Maybe that's the real problem to be addressed here. |
|
I'm closing this because this doesn't really fix the root problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assertion failure created by the scenario
outlined here:
#6598 (comment)
When a client gets disconnected from a network game that has an AI, and
then crashes, it tries to write a crash.sav. Attempting to save the AI
instance here, which doesn't exist on the client, causes the assertion
failure.
This change allows openttd to crash properly in this awkward scenario :P
crash.sav and crash.png are now written: