Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejabberd: 19.05 -> 19.08 #66215

Merged
merged 2 commits into from Aug 23, 2019
Merged

ejabberd: 19.05 -> 19.08 #66215

merged 2 commits into from Aug 23, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 6, 2019

Motivation for this change

New upstream release.

This probably has some conflicts with #63150.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @svanderburg

@ofborg ofborg bot added the 6.topic: nixos label Aug 6, 2019
@ofborg ofborg bot requested review from svanderburg and abbradar August 6, 2019 16:09
@abbradar
Copy link
Member

abbradar commented Aug 9, 2019

@GrahamcOfBorg test ejabberd

@abbradar
Copy link
Member

abbradar commented Aug 9, 2019

I don't have a ejabberd setup right now; did you test it with real users? Not mandatory, just would give more peace of mind.

@ajs124
Copy link
Member Author

ajs124 commented Aug 9, 2019

Yes. I run this "productively". I'm more or less the only active user, but I can confirm this works.

@ajs124
Copy link
Member Author

ajs124 commented Aug 20, 2019

Merge conflict fixed.

@Izorkin
Copy link
Contributor

Izorkin commented Aug 20, 2019

@GrahamcOfBorg test ejabberd

@Lassulus
Copy link
Member

tested with nix-review. everything looked good.

@Lassulus Lassulus merged commit 8b12bfc into NixOS:master Aug 23, 2019
@ajs124 ajs124 deleted the ejabberd/19.08 branch August 23, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @abbradar @Izorkin @Lassulus